A One-Line TF-A Fix, and the Review That Came With It
TL;DR
- The patch deletes one line — a leftover
GICV2_G0_FOR_EL3 := 1override inplat/rockchip/rk3576/platform.mkthat was both redundant (the tree-wide default is already0) and wrong (RK3576 has no reason to route GICv2 Group 0 to EL3). - It’s still the first thing I sent to Trusted Firmware-A, and it got read closely by engineers from ST, Google, and Rockchip before it landed.
- The point isn’t the diff size — it’s what upstream review actually asks of you even when the change is nearly nothing: is this safe for every configuration, not just yours?